Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an incorrect scoped function call (introduced in #1093) #1124

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

mahaloz
Copy link
Contributor

@mahaloz mahaloz commented Jul 18, 2024

Description

In #1093, a call to add_context_layout_mapping was added without the self scoping, causing a crash when external plugins add a context pane to GEF. I triggered this in the latest version of d2d:

Python Exception <class 'NameError'>: name 'add_context_layout_mapping' is not defined
Error occurred in Python: name 'add_context_layout_mapping' is not defined

Checklist

  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • If my change adds new code, adequate tests have been added.
  • I have read and agree to the CONTRIBUTING document.

Other Recommendations

If possible, I'd recommend adding a linter check as a requirement to the CI, so simple bugs like this can be caught :).

Copy link

🤖 Coverage update for 2066ca0 🟢

Old New
Commit 6ddd780 2066ca0
Score 71.6649% 71.6649% (0)

@Grazfather Grazfather merged commit d8c7723 into hugsy:main Jul 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants